-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create fw lite shared #1285
Merged
Merged
create fw lite shared #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myieye
previously approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through it commit by commit (thanks for the good manageable chunks).
I didn't see anything off. 👍
# Conflicts: # backend/FwLite/FwLiteDesktop/FwLiteDesktop.csproj # backend/FwLite/FwLiteProjectSync.Tests/Fixtures/SyncFixture.cs # backend/FwLite/LocalWebApp/LocalWebApp.csproj # backend/FwLite/LocalWebApp/Routes/HistoryRoutes.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while I was working on the blazor migration I noticed a bunch of services that needed to be moved into a common location so they can be shared between desktop and web. This is a first pass at that, there's probably more that will need to be done, but for now this moves most of our services out of LocalWebApp so they can be used outside of the context of a web server