Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create fw lite shared #1285

Merged
merged 14 commits into from
Nov 29, 2024
Merged

create fw lite shared #1285

merged 14 commits into from
Nov 29, 2024

Conversation

hahn-kev
Copy link
Collaborator

while I was working on the blazor migration I noticed a bunch of services that needed to be moved into a common location so they can be shared between desktop and web. This is a first pass at that, there's probably more that will need to be done, but for now this moves most of our services out of LocalWebApp so they can be used outside of the context of a web server

Copy link

github-actions bot commented Nov 27, 2024

C# Unit Tests

98 tests  ±0   98 ✅ ±0   5s ⏱️ ±0s
15 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 44ed456. ± Comparison against base commit ada6d56.

♻️ This comment has been updated with latest results.

myieye
myieye previously approved these changes Nov 28, 2024
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through it commit by commit (thanks for the good manageable chunks).
I didn't see anything off. 👍

backend/FwLite/LocalWebApp/LocalWebApp.csproj Outdated Show resolved Hide resolved
# Conflicts:
#	backend/FwLite/FwLiteDesktop/FwLiteDesktop.csproj
#	backend/FwLite/FwLiteProjectSync.Tests/Fixtures/SyncFixture.cs
#	backend/FwLite/LocalWebApp/LocalWebApp.csproj
#	backend/FwLite/LocalWebApp/Routes/HistoryRoutes.cs
@hahn-kev hahn-kev merged commit 8b4f158 into develop Nov 29, 2024
16 checks passed
@hahn-kev hahn-kev deleted the chore/create-fw-lite-shared branch November 29, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants